Medium-level API: Add AudioAccessor with corresponding functions. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AudioAccessor` in ptr_wrappers.rs `create_track_audio_accessor` `create_take_audio_accessor` `destroy_audio_accessor` `audio_accessor_state_changed` `audio_accessor_update` `audio_accessor_validate_state` `get_audio_accessor_end_time` `get_audio_accessor_start_time` `get_audio_accessor_samples` `GetAudioAccessorHash` is not wrapped, as it is deprecated. Low-level API: Fixed AudioAccessor to be ReaperPointer applied cargo fmt restricted to MainThreadOnly
|
Oh, by the way! I've found, that exiting because of the signal is, probably, normal way of exiting in Linux. So, maybe, there is a point to return |
Levitanus
force-pushed
the
stable_for_rea-rs
branch
from
517e94e
to
6fb1ec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry. This is a sort of duplicate, but, I hope, ready to push.
I've found the plan of making all the medium-level quite a big task, that I can't handle. Especially, in terms of psychical comfort ;)
So, since I (hope, not alone) really need to use ReaScript from rust somehow, I've built some sort of high-level on top of
reaper-low(and a bit ofreaper-medium). Until you introduce your rx architecture, I would like to consider this as a solution.But, at first, it requires this particular fix of reintroducing
AudioAccessorin low- and mid-levels. And, at the second, I would like to publish on crates.io, which requires all dependencies be there two. Also, when I first metreaper-rs, I also was confused a bit, until used GitHub dependency. May You also make a release on crates.io?I'll return to my pulls as soon as possible. Hope to polish that, which already sketched until the end of the year.
Changed
AudioAccessorin ptr_wrappers.rscreate_track_audio_accessorcreate_take_audio_accessordestroy_audio_accessoraudio_accessor_state_changedaudio_accessor_updateaudio_accessor_validate_stateget_audio_accessor_end_timeget_audio_accessor_start_timeget_audio_accessor_samplesGetAudioAccessorHashis not wrapped, as it is deprecated. Low-level API: Fixed AudioAccessor to be ReaperPointerapplied
cargo fmt